glvisualize backend #374
glvisualize backend #374
Conversation
| @@ -26,18 +26,18 @@ macro init_backend(s) | |||
| end) | |||
| end | |||
|
|
|||
| @init_backend Immerse | |||
| @init_backend Gadfly | |||
There was a problem hiding this comment.
Is there a reason you commented these out?
|
|
okay this starts looking okay!
Here's a little (badly compressed) gif: It's embarrassing slow though, since GLVisualize and Plots build up the complete plot for every frame which is completely unnecessary! ;) Will need to figure out a API/hijack the existing one, to bypass this! |
|
can someone try this out?! :) |
|
gotta be on: |
|
Should we merge this? |
|
We should, but I'm traveling right now. Did you rebase on a recent dev? On Thursday, September 1, 2016, Simon notifications@github.com wrote:
|
|
What a historic day... 🎉 🎉 🎉 |
| @@ -309,15 +309,13 @@ function expand_extrema!(sp::Subplot, d::KW) | |||
|
|
|||
| # expand for bar_width | |||
| if d[:seriestype] == :bar | |||
| dsym = vert ? :x : :y | |||
| dsym = (!vert) ? :x : :y | |||
There was a problem hiding this comment.
I just reverted this change... any idea why you did this? The idea is that it's setting a default bar width and expanding the axis extrema. When the plot is vertical, we want to update the x axis.
There was a problem hiding this comment.
Well, it was skewed in the wrong direction so I changed this and then it was working...
Work in progress for the GLVisualize backend